Template talk:Header blue: Difference between revisions

From Wikimedia UK
Jump to navigation Jump to search
m (ce)
(now live)
 
(6 intermediate revisions by 2 users not shown)
Line 1: Line 1:
This template seems to be generating quite a large gap between the bottom of the header and the top of the text, which looks a bit odd, but I can't spot why... Thanks. [[User:Mike Peel|Mike Peel]] ([[User talk:Mike Peel|talk]]) 19:05, 19 February 2014 (UTC)
This template seems to be generating quite a large gap between the bottom of the header and the top of the text, which looks a bit odd, but I can't spot why... Thanks. [[User:Mike Peel|Mike Peel]] ([[User talk:Mike Peel|talk]]) 19:05, 19 February 2014 (UTC)
:What do you mean by "quite a large gap"? Can you provide a screenshot? On [[User:Katie Chan (WMUK)/sandbox]], it's the same gap as any other h2 header (when measure from the bottom of the blue in the first case vs. horizontal rule in the second). -- [[User:Katie Chan (WMUK)|Katie Chan (WMUK)]] ([[User talk:Katie Chan (WMUK)|talk]]) 19:32, 19 February 2014 (UTC)
:What do you mean by "quite a large gap"? Can you provide a screenshot? On [[User:Katie Chan (WMUK)/sandbox]], it's the same gap as any other h2 header (when measure from the bottom of the blue in the first case vs. horizontal rule in the second). -- [[User:Katie Chan (WMUK)|Katie Chan (WMUK)]] ([[User talk:Katie Chan (WMUK)|talk]]) 19:32, 19 February 2014 (UTC)
:: See [http://www.mikepeel.net/temp/screenshot.png]. The gap seems to be bigger on the main page than your sandbox page. Thanks. [[User:Mike Peel|Mike Peel]] ([[User talk:Mike Peel|talk]]) 19:44, 19 February 2014 (UTC)
:::That's part of [[:Template:Main Page]]. The blue section headers are in a table layout as table header <nowiki><th></nowiki> that has its own padding (margin?) set. -- [[User:Katie Chan (WMUK)|Katie Chan (WMUK)]] ([[User talk:Katie Chan (WMUK)|talk]]) 20:01, 19 February 2014 (UTC)
:::: Ah, OK. I can't spot where that padding/margin is being set there, though... Thanks. [[User:Mike Peel|Mike Peel]] ([[User talk:Mike Peel|talk]]) 20:19, 19 February 2014 (UTC)
:::::If there's any specific styling, it's part of the standard mediawiki/vector theme skin CSS that have not been overridden. On further investigation, it's not just one padding/margin tied to one specific element. Taking "About Wikimedia UK" section as an example, there's a margin (~9px) under the blue bits as part of h2, which is surrounded by 2px of padding as part of th. Next there is margin (~5px) at the top of the first paragraph of text, plus that tiny bit as part of line-height. Add in 2px of padding as part of the td cell of content. I'm also not convinced there's not a few extra pixels hiding in between different elements because the number doesn't seems to add up, but that might just be limitation of Chrome Developer Tools. -- [[User:Katie Chan (WMUK)|Katie Chan (WMUK)]] ([[User talk:Katie Chan (WMUK)|talk]]) 21:01, 19 February 2014 (UTC)
::::::[[Main Page/Sandbox]] has less white space under the blue headers. What do you (and anyone else reading) think? -- [[User:Katie Chan (WMUK)|Katie Chan (WMUK)]] ([[User talk:Katie Chan (WMUK)|talk]]) 12:52, 20 February 2014 (UTC)
::::::: That looks good. Thanks. [[User:Mike Peel|Mike Peel]] ([[User talk:Mike Peel|talk]]) 13:32, 20 February 2014 (UTC)
::::::::I've made the changes live. -- [[User:Katie Chan (WMUK)|Katie Chan (WMUK)]] ([[User talk:Katie Chan (WMUK)|talk]]) 15:56, 20 February 2014 (UTC)

Latest revision as of 16:56, 20 February 2014

This template seems to be generating quite a large gap between the bottom of the header and the top of the text, which looks a bit odd, but I can't spot why... Thanks. Mike Peel (talk) 19:05, 19 February 2014 (UTC)

What do you mean by "quite a large gap"? Can you provide a screenshot? On User:Katie Chan (WMUK)/sandbox, it's the same gap as any other h2 header (when measure from the bottom of the blue in the first case vs. horizontal rule in the second). -- Katie Chan (WMUK) (talk) 19:32, 19 February 2014 (UTC)
See [1]. The gap seems to be bigger on the main page than your sandbox page. Thanks. Mike Peel (talk) 19:44, 19 February 2014 (UTC)
That's part of Template:Main Page. The blue section headers are in a table layout as table header <th> that has its own padding (margin?) set. -- Katie Chan (WMUK) (talk) 20:01, 19 February 2014 (UTC)
Ah, OK. I can't spot where that padding/margin is being set there, though... Thanks. Mike Peel (talk) 20:19, 19 February 2014 (UTC)
If there's any specific styling, it's part of the standard mediawiki/vector theme skin CSS that have not been overridden. On further investigation, it's not just one padding/margin tied to one specific element. Taking "About Wikimedia UK" section as an example, there's a margin (~9px) under the blue bits as part of h2, which is surrounded by 2px of padding as part of th. Next there is margin (~5px) at the top of the first paragraph of text, plus that tiny bit as part of line-height. Add in 2px of padding as part of the td cell of content. I'm also not convinced there's not a few extra pixels hiding in between different elements because the number doesn't seems to add up, but that might just be limitation of Chrome Developer Tools. -- Katie Chan (WMUK) (talk) 21:01, 19 February 2014 (UTC)
Main Page/Sandbox has less white space under the blue headers. What do you (and anyone else reading) think? -- Katie Chan (WMUK) (talk) 12:52, 20 February 2014 (UTC)
That looks good. Thanks. Mike Peel (talk) 13:32, 20 February 2014 (UTC)
I've made the changes live. -- Katie Chan (WMUK) (talk) 15:56, 20 February 2014 (UTC)